


cppcheck	dovecot	1	35715
struct or union member 'master_userdb_request::auth_request' is never used
Comment : Looks ok. I can't see any usage of struct master_userdb_request at all.


cppcheck	dovecot	7	35721
Unused variable: value
Comment: might be considered a false positive, "value" can't just be removed.


cppcheck	dovecot	12	35726
Variable 'callback' is assigned a value that is never used
Comment: false positive


cppcheck	dovecot	13	35727
Variable 'callback' is assigned a value that is never used
Comment: false positive


cppcheck	dovecot	19	35733
The scope of the variable ret can be reduced
Comment: Looks correct.


cppcheck	dovecot	20	35734
Resource leak: fd
Comment: Looks correct.


cppcheck	dovecot	21	35735
Resource leak: fd
Comment: Looks correct.


cppcheck	dovecot	36	35750
struct or union member 'search_build_data::box' is never used
Comment: Looks correct. I can't see any usage of struct search_build_data at all


cppcheck	dovecot	37	35751
struct or union member 'search_build_data::error' is never used
Comment: Looks correct. See above warning.


cppcheck	dovecot	55	35769
The scope of the variable ret can be reduced
Comment: Looks correct


cppcheck	dovecot	60	35774
The scope of the variable pos can be reduced
Comment: Looks correct


cppcheck	dovecot	66	35780
Variable 'hdr' is not assigned a value
Comment: Looks correct.


cppcheck	dovecot	75	35789
The scope of the variable ret can be reduced
Comment: Looks correct.


cppcheck	dovecot	77	35791
After a strncpy() the buffer should be zero-terminated
Comment: The code is not bad. However this is only reported as a stylistic issue by Cppcheck.


cppcheck	dovecot	79	35793
Variable 'db' is assigned a value that is never used
Comment: Might be a false positive, "db" can't just be removed


cppcheck	dovecot	83	35797
The scope of the variable i can be reduced
Comment: Looks correct.


cppcheck	dovecot	85	35799
Variable 'pos' is assigned a value that is never used
Comment: False positive. But pos can be removed.


cppcheck	dovecot	87	35801
The scope of the variable ret can be reduced
Comment: Looks correct.


cppcheck	dovecot	89	35803
The scope of the variable count can be reduced
Comment: Looks correct.


cppcheck	dovecot	98	35812
The scope of the variable ret can be reduced
Comment: Looks correct.


cppcheck	dovecot	102	35816
The scope of the variable key can be reduced
Comment: Looks correct.


cppcheck	dovecot	112	35826
The scope of the variable need_space can be reduced
Comment: Looks correct.


cppcheck	dovecot	119	35833
The scope of the variable ret can be reduced
Comment: Looks correct.


cppcheck	dovecot	121	35835
The scope of the variable found can be reduced
Comment: Looks correct.


cppcheck	dovecot	129	35843
Variable 'sasl_callback' is assigned a value that is never used
Comment: False positive


cppcheck	dovecot	142	35856
Resource leak: fd
Comment: Looks correct. There are resource leaks that Cppcheck misses because it abstracts and simplifies the code. 
If you fix this resource leak then there _should_ be a new warning about line 137. 


cppcheck	dovecot	145	35859
The scope of the variable mask can be reduced
Comment: Looks correct.


cppcheck	dovecot	166	35880
The scope of the variable fd can be reduced
Comment: Looks correct.


cppcheck	dovecot	168	35882
struct or union member 'client::output' is never used
Comment: Looks correct.


cppcheck	dovecot	169	35883
Resource leak: fd
Comment: Resource leak in main() .. this might be considered a false positive.
