LDRA Testbed Code Review Report

LDRA Testbed ® Code Review Report

# System : Dovecot-src-log

Overall Result: FAIL

Report Production | Report Configuration | Analysis phases
--- | --- | ---
C/C++ LDRA Testbed Version: 8.3.0 Config. File: C:\Testbed\CCPP_830_Release\C\sate_creport.dat Produced On: Mon Aug 09 2010 at 20:06:11 Penalty File: C:\Testbed\CCPP_830_Release\c\cpen.dat | Report Level: Summary Report Procedures Reported: Fails Only Programming Standards Model: SATE 2010 L1 Plus Line Numbers refer to: Original Source File Violation Details: Violations Only Reporting Scope: Full analysis scope | Static: Yes Complexity: Yes Static Data Flow: Yes Information Flow: Yes Cross Reference: Yes

#### Contents

Overall Quality Summary

- Totals of Violations for each Standard
- Table of Procedure Results
- Table of Source Files in System
- Table of Global Basic Information

Report on Program Components

- Quality Results Global Program and Selected Procedures

## Overall Quality Summary

#### Totals for Violated Quality Standards

Number of Violations | LDRA Code | (M) Mandatory Standards | CERT Code
--- | --- | --- | ---
73 | 77 S | Macro replacement list needs parentheses. | CERT PRE02-C
46 | 78 S | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
1 | 483 S | free parameter is not heap item. | CERT MEM34-C
6 | 5 D | Procedure contains UR data flow anomalies. | CERT EXP33-C
34 | 45 D | Pointer not checked for null before use | CERT EXP08-C,EXP34-C
3 | 51 D | Attempt to read from freed memory. | CERT MEM30-C
1 | 57 D | Global not initialised at declaration. | CERT EXP33-C
13 | 69 D | Procedure contains UR data flow anomalies. | CERT EXP33-C
1 | 77 D | Local structure returned in function result |

Number of Violations | LDRA Code | (C) Checking (Mandatory) Standards | CERT Code
--- | --- | --- | ---
2 | 76 D | Procedure not called in code analysed |

Number of Violations | LDRA Code | (O) Optional Standards | CERT Code
--- | --- | --- | ---

No Optional Standards Violated

Number of Mandatory Standards checked | 27
Number of Checking Standards checked | 1
Number of Optional Standards checked | 3
Total Standards checked | 31

### OVERALL RESULT: FAIL

Out of 35 program components, 19 (54.29 %) pass ( of which 0 conditionally pass ) and 16 fail ( of which 0 fail only because of insufficient comments )

#### Procedure Results

`Quality Result` |  | `Procedure` |  | `Source File` |  | `Unique Violations` |  | `Failure Density` |
`` |  |  |  |  | `(Viols/R.Line %)` |
FAIL |  | Global Program |
Pass |  | buffer_get_data |  | buffer.h analysed in log-connection.c |  | 0 |  | 0 |
Pass |  | buffer_get_used_size |  | buffer.h analysed in log-connection.c |  | 0 |  | 0 |
Pass |  | array_create_from_buffer_i |  | array.h analysed in log-connection.c |  | 0 |  | 0 |
FAIL |  | array_create_i |  | array.h analysed in log-connection.c |  | 3 | - |  | 17 | - |
Pass |  | array_free_i |  | array.h analysed in log-connection.c |  | 0 |  | 0 |
Pass |  | array_is_created_i |  | array.h analysed in log-connection.c |  | 0 |  | 0 |
Pass |  | array_get_pool_i |  | array.h analysed in log-connection.c |  | 0 |  | 0 |
Pass |  | array_clear_i |  | array.h analysed in log-connection.c |  | 0 |  | 0 |
Pass |  | array_append_i |  | array.h analysed in log-connection.c |  | 0 |  | 0 |
Pass |  | array_append_array_i |  | array.h analysed in log-connection.c |  | 0 |  | 0 |
Pass |  | array_insert_i |  | array.h analysed in log-connection.c |  | 0 |  | 0 |
Pass |  | array_delete_i |  | array.h analysed in log-connection.c |  | 0 |  | 0 |
Pass |  | array_get_i |  | array.h analysed in log-connection.c |  | 0 |  | 0 |
Pass |  | array_idx_i |  | array.h analysed in log-connection.c |  | 0 |  | 0 |
Pass |  | array_get_modifiable_i |  | array.h analysed in log-connection.c |  | 0 |  | 0 |
Pass |  | array_append_space_i |  | array.h analysed in log-connection.c |  | 0 |  | 0 |
Pass |  | array_copy |  | array.h analysed in log-connection.c |  | 0 |  | 0 |
Pass |  | array_count_i |  | array.h analysed in log-connection.c |  | 0 |  | 0 |
FAIL |  | log_client_get |  | log-connection.c |  | 3 | - |  | 6 | - |
FAIL |  | log_client_free |  | log-connection.c |  | 3 | - |  | 23 | - |
FAIL |  | log_parse_option |  | log-connection.c |  | 3 | - |  | 12 | - |
FAIL |  | log_parse_master_line |  | log-connection.c |  | 10 | - |  | 9 | - |
FAIL |  | log_it |  | log-connection.c |  | 10 | - |  | 10 | - |
FAIL |  | log_connection_handshake |  | log-connection.c |  | 10 | - |  | 4 | - |
FAIL |  | log_connection_input |  | log-connection.c |  | 3 | - |  | 3 | - |
FAIL |  | log_connection_create |  | log-connection.c |  | 7 | - |  | 22 | - |
FAIL |  | log_connection_destroy |  | log-connection.c |  | 17 | - |  | 18 | - |
FAIL |  | log_connections_init |  | log-connection.c |  | 3 | - |  | 80 | - |
FAIL |  | log_connections_deinit |  | log-connection.c |  | 10 | - |  | 21 | - |
FAIL |  | sig_reopen_logs |  | main.c |  | 3 | - |  | 33 | - |
Pass |  | main_init |  | main.c |  | 0 |  | 0 |
Pass |  | main_deinit |  | main.c |  | 0 |  | 0 |
FAIL |  | client_connected |  | main.c |  | 3 | - |  | 25 | - |
FAIL |  | main |  | main.c |  | 10 | - |  | 24 | - |

#### Global Information

#### Source Files in System

Name | Last Modification Date
--- | ---
C:\Code\SAMATE\SATE2010\dovecot-2.0.beta6.20100626\dovecot-2.0.beta6\src\log\main.c | Thu May 27 19:00:08 2010
C:\Code\SAMATE\SATE2010\dovecot-2.0.beta6.20100626\dovecot-2.0.beta6\src\log\log-settings.c | Fri Jun 25 08:22:16 2010
C:\Code\SAMATE\SATE2010\dovecot-2.0.beta6.20100626\dovecot-2.0.beta6\src\log\log-connection.c | Fri Mar 26 07:16:36 2010

#### Global Basic Information

Number of procedures: | 34
Number of locally uncalled procedures: | 0
Maximum loop depth: | 1
Total Cyclomatic Complexity: | 46
Number of reformatted executable lines: | 587
Number of lines of comments: | 2110

## Summary Report on all Program Components which FAIL

Globals / code outside procedures - FAIL

#### Standards Violation Summary - All files

Code | File: Src Line | Violation | Standard
--- | --- | --- | ---
M | compat.h: 214 | Macro replacement list needs parentheses. | CERT PRE02-C
M | compat.h: 215 | Macro replacement list needs parentheses. | CERT PRE02-C
M | compat.h: 216 | Macro replacement list needs parentheses. | CERT PRE02-C
M | compat.h: 217 | Macro replacement list needs parentheses. | CERT PRE02-C
M | compat.h: 218 | Macro replacement list needs parentheses. | CERT PRE02-C
M | compat.h: 219 | Macro replacement list needs parentheses. | CERT PRE02-C
M | compat.h: 220 | Macro replacement list needs parentheses. | CERT PRE02-C
M | compat.h: 221 | Macro replacement list needs parentheses. | CERT PRE02-C
M | compat.h: 222 | Macro replacement list needs parentheses. | CERT PRE02-C
M | compat.h: 223 | Macro replacement list needs parentheses. | CERT PRE02-C
M | compat.h: 224 | Macro replacement list needs parentheses. | CERT PRE02-C
M | compat.h: 225 | Macro replacement list needs parentheses. | CERT PRE02-C
M | compat.h: 226 | Macro replacement list needs parentheses. | CERT PRE02-C
M | macros.h: 196 | Macro replacement list needs parentheses. | CERT PRE02-C
M | macros.h: 197 | Macro replacement list needs parentheses. | CERT PRE02-C
M | macros.h: 204 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | macros.h: 204 | Macro replacement list needs parentheses. | CERT PRE02-C
M | macros.h: 205 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | macros.h: 205 | Macro replacement list needs parentheses. | CERT PRE02-C
M | macros.h: 223 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | macros.h: 223 | Macro replacement list needs parentheses. | CERT PRE02-C
M | macros.h: 232 | Macro replacement list needs parentheses. | CERT PRE02-C
M | data-stack.h: 49 | Macro replacement list needs parentheses. | CERT PRE02-C
M | data-stack.h: 51 | Macro replacement list needs parentheses. | CERT PRE02-C
M | data-stack.h: 75 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | data-stack.h: 85 | Macro replacement list needs parentheses. | CERT PRE02-C
M | data-stack.h: 90 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | data-stack.h: 90 | Macro replacement list needs parentheses. | CERT PRE02-C
M | data-stack.h: 97 | Macro replacement list needs parentheses. | CERT PRE02-C
M | mempool.h: 84 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | mempool.h: 87 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | mempool.h: 88 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | mempool.h: 99 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | mempool.h: 99 | Macro replacement list needs parentheses. | CERT PRE02-C
M | mempool.h: 102 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | mempool.h: 102 | Macro replacement list needs parentheses. | CERT PRE02-C
M | imem.h: 8 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | imem.h: 8 | Macro replacement list needs parentheses. | CERT PRE02-C
M | imem.h: 14 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | imem.h: 14 | Macro replacement list needs parentheses. | CERT PRE02-C
M | imem.h: 15 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | imem.h: 15 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array-decl.h: 4 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array-decl.h: 4 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array-decl.h: 7 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array-decl.h: 7 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array-decl.h: 9 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array-decl.h: 9 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 35 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 35 | Macro replacement list needs parentheses. | CERT PRE02-C

Code | File: Src Line | Violation | Standard
--- | --- | --- | ---
M | array.h: 37 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 37 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 39 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 39 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 53 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 58 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 58 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 62 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 62 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 90 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 90 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 102 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 102 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 110 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 118 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 126 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 134 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 143 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 143 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 153 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 164 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 164 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 174 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 174 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 183 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 183 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 192 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 192 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 201 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 201 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 206 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 206 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 211 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 211 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 216 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 216 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 228 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 232 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 232 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 252 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 257 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 261 | Macro replacement list needs parentheses. | CERT PRE02-C
M | array.h: 266 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 279 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | array.h: 279 | Macro replacement list needs parentheses. | CERT PRE02-C
M | ioloop.h: 50 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | ioloop.h: 50 | Macro replacement list needs parentheses. | CERT PRE02-C
M | ioloop.h: 56 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | ioloop.h: 75 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | ioloop.h: 75 | Macro replacement list needs parentheses. | CERT PRE02-C

Code | File: Src Line | Violation | Standard
--- | --- | --- | ---
M | istream.h: 53 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | istream.h: 53 | Macro replacement list needs parentheses. | CERT PRE02-C
M | llist.h: 5 | Macro replacement list needs parentheses. | CERT PRE02-C
M | llist.h: 12 | Macro replacement list needs parentheses. | CERT PRE02-C
M | llist.h: 25 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | llist.h: 25 | Macro replacement list needs parentheses. | CERT PRE02-C
M | llist.h: 32 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | llist.h: 32 | Macro replacement list needs parentheses. | CERT PRE02-C
M | llist.h: 39 | Macro replacement list needs parentheses. | CERT PRE02-C
M | log-connection.c: 42 | Global not initialised at declaration. : logs_by_fd | CERT EXP33-C
M | settings-parser.h: 46 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | settings-parser.h: 46 | Macro replacement list needs parentheses. | CERT PRE02-C
M | settings-parser.h: 50 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | settings-parser.h: 50 | Macro replacement list needs parentheses. | CERT PRE02-C
M | settings-parser.h: 54 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | settings-parser.h: 54 | Macro replacement list needs parentheses. | CERT PRE02-C
M | settings-parser.h: 58 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | settings-parser.h: 58 | Macro replacement list needs parentheses. | CERT PRE02-C
M | settings-parser.h: 62 | Macro parameter not in brackets. | CERT PRE01-C,PRE02-C
M | settings-parser.h: 62 | Macro replacement list needs parentheses. | CERT PRE02-C

[ | Top of Report | | | Procedure Table | | | Contents | ]

array_create_i (93 to 101 array.h analysed in log-connection.c) - FAIL

#### Standards Violation Summary

Code | Line | Violation | Standard
--- | --- | --- | ---
M | 100 | Pointer not checked for null before use : buffer | CERT EXP08-C,EXP34-C
| 99 |  |

[ | Top of Report | | | Procedure Table | | | Contents | ]

log_client_get (44 to 54 log-connection.c) - FAIL

#### Standards Violation Summary

Code | Line | Violation | Standard
--- | --- | --- | ---
M | 51 | Pointer not checked for null before use : client | CERT EXP08-C,EXP34-C
| 50 |  |

[ | Top of Report | | | Procedure Table | | | Contents | ]

log_client_free (56 to 63 log-connection.c) - FAIL

#### Standards Violation Summary

Code | Line | Violation | Standard
--- | --- | --- | ---
M | 62 | Pointer not checked for null before use : default_pool | CERT EXP08-C,EXP34-C
| 61 |  |
M | 62 | Pointer not checked for null before use : (client)->prefix | CERT EXP08-C,EXP34-C
| 61 |  |
M | 61 | Pointer not checked for null before use : default_pool | CERT EXP08-C,EXP34-C
| Ref. Line -1101 (Module 760) |  |

[ | Top of Report | | | Procedure Table | | | Contents | ]

log_parse_option (65 to 77 log-connection.c) - FAIL

#### Standards Violation Summary

Code | Line | Violation | Standard
--- | --- | --- | ---
M | 70 | Pointer not checked for null before use : default_pool | CERT EXP08-C,EXP34-C
| Ref. Line -1101 (Module 760) |  |
M | 72 | Pointer not checked for null before use : client | CERT EXP08-C,EXP34-C
| 70 |  |
M | 74 | Pointer not checked for null before use : client | CERT EXP08-C,EXP34-C
| 70 |  |

[ | Top of Report | | | Procedure Table | | | Contents | ]

log_parse_master_line (79 to 123 log-connection.c) - FAIL

#### Standards Violation Summary

Code | Violation | Standard
--- | --- | ---
M | Procedure contains UR data flow anomalies. | CERT EXP33-C

Code | Line | Violation | Standard
--- | --- | --- | ---
M | 103 | Pointer not checked for null before use : log | CERT EXP08-C,EXP34-C
| 102 |  |
M | 106 | Pointer not checked for null before use : line | CERT EXP08-C,EXP34-C
| 104 |  |
M | 102 | Pointer not checked for null before use : logs | CERT EXP08-C,EXP34-C
| 96 |  |
M | 112 | Pointer not checked for null before use : client | CERT EXP08-C,EXP34-C
| 103 |  |
M | 119 | Pointer not checked for null before use : client | CERT EXP08-C,EXP34-C
| 103 |  |
M | 83 | Procedure contains UR data flow anomalies. : p2 | CERT EXP33-C
| 104 |  |

#### Possible UR Anomalies

The following variables may be referenced before being given a value

File | Undefine | File | Reference | Variable
--- | --- | --- | --- | ---
log-connection.c | 83 | log-connection.c | 104 | p2

[ | Top of Report | | | Procedure Table | | | Contents | ]

log_it (125 to 158 log-connection.c) - FAIL

#### Standards Violation Summary

Code | Violation | Standard
--- | --- | ---
M | Procedure contains UR data flow anomalies. | CERT EXP33-C

Code | Line | Violation | Standard
--- | --- | --- | ---
M | 141 | Pointer not checked for null before use : client | CERT EXP08-C,EXP34-C
| 140 |  |
M | 155 | Pointer not checked for null before use : prefix | CERT EXP08-C,EXP34-C
| 153 |  |
M | 127 | Procedure contains UR data flow anomalies. : failure.log_type | CERT EXP33-C
| 136 |  |
M | 127 | Procedure contains UR data flow anomalies. : failure.pid | CERT EXP33-C
| 136 |  |
M | 127 | Procedure contains UR data flow anomalies. : failure.text | CERT EXP33-C
| 136 |  |

#### Possible UR Anomalies

The following variables may be referenced before being given a value

File | Undefine | File | Reference | Variable
--- | --- | --- | --- | ---
log-connection.c | 127 | log-connection.c | 136 | failure.log_type
log-connection.c | 127 | log-connection.c | 136 | failure.pid
log-connection.c | 127 | log-connection.c | 136 | failure.text

[ | Top of Report | | | Procedure Table | | | Contents | ]

log_connection_handshake (160 to 204 log-connection.c) - FAIL

#### Standards Violation Summary

Code | Violation | Standard
--- | --- | ---
M | Procedure contains UR data flow anomalies. | CERT EXP33-C

Code | Line | Violation | Standard
--- | --- | --- | ---
M | 179 | Pointer not checked for null before use : data | CERT EXP08-C,EXP34-C
| 177 |  |
M | 164 | Procedure contains UR data flow anomalies. : size | CERT EXP33-C
| 177 |  |

#### Possible UR Anomalies

The following variables may be referenced before being given a value

File | Undefine | File | Reference | Variable
--- | --- | --- | --- | ---
log-connection.c | 164 | log-connection.c | 177 | size

[ | Top of Report | | | Procedure Table | | | Contents | ]

log_connection_input (206 to 228 log-connection.c) - FAIL

#### Standards Violation Summary

Code | Line | Violation | Standard
--- | --- | --- | ---
M | 221 | Pointer not checked for null before use : default_pool | CERT EXP08-C,EXP34-C
| 218 |  |
M | 224 | Pointer not checked for null before use : default_pool | CERT EXP08-C,EXP34-C
| 218 |  |

[ | Top of Report | | | Procedure Table | | | Contents | ]

log_connection_create (230 to 246 log-connection.c) - FAIL

#### Standards Violation Summary

Code | Line | Violation | Standard
--- | --- | --- | ---
M | 245 | Local structure returned in function result : log |
M | 235 | Pointer not checked for null before use : log | CERT EXP08-C,EXP34-C
| 234 |  |
M | 239 | Pointer not checked for null before use : default_pool | CERT EXP08-C,EXP34-C
| Ref. Line -1101 (Module 760) |  |
M | 241 | Pointer not checked for null before use : logs_by_fd.v_modifiable | CERT EXP08-C,EXP34-C
| 42 |  |
M | 241 | Pointer not checked for null before use : logs_by_fd.v | CERT EXP08-C,EXP34-C
| 42 |  |
M | 241 | Pointer not checked for null before use : logs_by_fd.arr.buffer | CERT EXP08-C,EXP34-C
| 42 |  |

[ | Top of Report | | | Procedure Table | | | Contents | ]

log_connection_destroy (248 to 272 log-connection.c) - FAIL

#### Standards Violation Summary

Code | Violation | Standard
--- | --- | ---
M | Attempt to read from freed memory. : value | CERT MEM30-C
M | Procedure contains UR data flow anomalies. | CERT EXP33-C

Code | Line | Violation | Standard
--- | --- | --- | ---
M | 259 | free parameter is not heap item. | CERT MEM34-C
M | 269 | Pointer not checked for null before use : default_pool | CERT EXP08-C,EXP34-C
| 268 |  |
M | 269 | Pointer not checked for null before use : (log)->default_prefix | CERT EXP08-C,EXP34-C
| 268 |  |
M | 253 | Pointer not checked for null before use : logs_by_fd.v_modifiable | CERT EXP08-C,EXP34-C
| 42 |  |
M | 253 | Pointer not checked for null before use : logs_by_fd.v | CERT EXP08-C,EXP34-C
| 42 |  |
M | 253 | Pointer not checked for null before use : logs_by_fd.arr.buffer | CERT EXP08-C,EXP34-C
| 42 |  |
M | 258 | Pointer not checked for null before use : value | CERT EXP08-C,EXP34-C
| 259 |  |
M | 251 | Procedure contains UR data flow anomalies. : key | CERT EXP33-C
| 258 |  |
M | 255 | Procedure contains UR data flow anomalies. : log_connections.prev | CERT EXP33-C

#### Possible UR Anomalies

The following variables may be referenced before being given a value

File | Undefine | File | Reference | Variable
--- | --- | --- | --- | ---
log-connection.c | 251 | log-connection.c | 258 | key

[ | Top of Report | | | Procedure Table | | | Contents | ]

log_connections_init (274 to 277 log-connection.c) - FAIL

#### Standards Violation Summary

Code | Line | Violation | Standard
--- | --- | --- | ---
M | 276 | Pointer not checked for null before use : logs_by_fd.v_modifiable | CERT EXP08-C,EXP34-C
| 42 |  |
M | 276 | Pointer not checked for null before use : logs_by_fd.v | CERT EXP08-C,EXP34-C
| 42 |  |
M | 276 | Pointer not checked for null before use : logs_by_fd.arr.buffer | CERT EXP08-C,EXP34-C
| 42 |  |
M | 276 | Pointer not checked for null before use : default_pool | CERT EXP08-C,EXP34-C
| Ref. Line -1101 (Module 760) |  |

[ | Top of Report | | | Procedure Table | | | Contents | ]

log_connections_deinit (279 to 286 log-connection.c) - FAIL

#### Standards Violation Summary

Code | Violation | Standard
--- | --- | ---
M | Procedure contains UR data flow anomalies. | CERT EXP33-C

Code | Line | Violation | Standard
--- | --- | --- | ---
M | 284 | Pointer not checked for null before use : log_connections | CERT EXP08-C,EXP34-C
| 284 |  |
M | 284 | Attempt to read from freed memory. : log_connections | CERT MEM30-C

#### Possible UR Anomalies

The following variables may be referenced before being given a value

File | Undefine | File | Reference | Variable
--- | --- | --- | --- | ---
log-connection.c | 255 | log-connection.c | 284 | log_connections.prev

[ | Top of Report | | | Procedure Table | | | Contents | ]

sig_reopen_logs (13 to 17 main.c) - FAIL

#### Standards Violation Summary

Code | Line | Violation | Standard
--- | --- | --- | ---
C | 13 | Procedure not called in code analysed : sig_reopen_logs |

[ | Top of Report | | | Procedure Table | | | Contents | ]

client_connected (31 to 35 main.c) - FAIL

#### Standards Violation Summary

Code | Line | Violation | Standard
--- | --- | --- | ---
C | 31 | Procedure not called in code analysed : client_connected |

[ | Top of Report | | | Procedure Table | | | Contents | ]

main (37 to 68 main.c) - FAIL

#### Standards Violation Summary

Code | Violation | Standard
--- | --- | ---
M | Procedure contains UR data flow anomalies. | CERT EXP33-C

Code | Line | Violation | Standard
--- | --- | --- | ---
M | 63 | Attempt to read from freed memory. : default_pool | CERT MEM30-C
M | 65 | Procedure contains UR data flow anomalies. : (default_pool)->v | CERT EXP33-C
M | 39 | Procedure contains UR data flow anomalies. : error | CERT EXP33-C
| 50 |  |
M | 63 | Procedure contains UR data flow anomalies. : logs_by_fd.arr.buffer | CERT EXP33-C
| 42 (log-connection.c) |  |
M | 63 | Procedure contains UR data flow anomalies. : logs_by_fd.arr.element_size | CERT EXP33-C
| 42 (log-connection.c) |  |
M | 63 | Procedure contains UR data flow anomalies. : logs_by_fd.v | CERT EXP33-C
| 42 (log-connection.c) |  |
M | 63 | Procedure contains UR data flow anomalies. : logs_by_fd.v_modifiable | CERT EXP33-C
| 42 (log-connection.c) |  |

#### Possible UR Anomalies

The following variables may be referenced before being given a value

File | Undefine | File | Reference | Variable
--- | --- | --- | --- | ---
[external declaration] |  | main.c | 65 | (default_pool)->v
main.c | 39 | main.c | 50 | error
[external declaration] |  | main.c | 63 | logs_by_fd.arr.buffer
[external declaration] |  | main.c | 63 | logs_by_fd.arr.element_size
[external declaration] |  | main.c | 63 | logs_by_fd.v
[external declaration] |  | main.c | 63 | logs_by_fd.v_modifiable

[ | Top of Report | | | Procedure Table | | | Contents | ]

### End of Code Review Report

###

### Copyright © 2010 Liverpool Data Research Associates