CodeSonar : pvm3.4.6 : Uninitialized Variable

pvm3.4.6 : pvm3.4.6 analysis 2 : Uninitialized Variable at lpvm.c:1527

Categories:	LANG.MEM.UVAR CWE:457
Warning ID:	408.29126
Procedure:	pvm_tc_taskexit
Trace:	view
Modified:	Thu Nov 26 11:34:38 2009 show details hide details

Priority:	None
State:	None
Finding:	None
Owner:	None
	edit properties

Analysis:

pvm3.4.6 analysis 2

Analysis ID:

Started:

Thu Nov 26 11:21:30 2009 show details hide details

by user:	fletcher
on host:	katrine.grammatech.com
at address:	10.233.219.127

Finished:

Thu Nov 26 11:39:55 2009 show logs hide logs

build:	[Full] [Streamed Full] [Tail] [Streamed Tail]
codesonar parse:	[Full] [Streamed Full] [Tail] [Streamed Tail]
codesonar analysis:	[Full] [Streamed Full] [Tail] [Streamed Tail]

Analysis State:

Finished

Detected:

Thu Nov 26 11:34:38 2009

First Detected:

Wed Oct 21 14:57:49 2009

Legend	[ X ]
Warning Location Contributes Parse Error Other Warning Two or More Loop Iterations On Execution Path Comment Macro Preprocessor Include Keyword Preprocessed Away

Legend
Warning Location	Contributes	Parse Error
Other Warning	Two or More Loop Iterations	On Execution Path
Comment	Macro	Preprocessor
Include	Keyword	Preprocessed Away

Source | Language: C

Show Legend Hide Legend

Problem	Line	Source

			/kat0/fletcher/SATE/2010/pvm3/src/lpvm.c

			Enter pvm_tc_taskexit

true

1511

pvm_tc_taskexit(mid)

x Problem
true

1512

int mid;

1513

{

1514

int tid; /* exited task id */

1515

struct ttpcb *pcbp;

1516

	1517		pvm_upkint(&tid, 1, 1);

					/kat0/fletcher/SATE/2010/pvm3/src/lpvmpack.c

					Enter pvm_tc_taskexit / pvm_upkint

1255

pvm_upkint(np, cnt, std)

int *np;

int cnt;

int std;

{

int cc;

long ad;

TEV_DECLS

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
135	#define TEV_DECLS int pvmamtraced; \
136	int pvmampushed = 0; \
137	int pvmtoplvlsave;

1263

1264

if (TEV_EXCLUSIVE) {

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
139	#define TEV_EXCLUSIVE ( (pvmamtraced = pvmtoplvl) != 0 \
140	&& (pvmtoplvl = 0) == 0 )

1265

if (TEV_DO_TRACE (TEV_UPKINT ,TEV_EVENT_ENTRY )) {

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
130	#define TEV_DO_TRACE( _kind, _entry_exit ) \
131	( TEV_CHECK_TRACE( _kind ) && tev_begin( _kind, _entry_exit ) )

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
124	#define TEV_CHECK_TRACE( _kind ) \
125	( !BEATASK && pvmtrc.trctid > 0 && pvmtrc.trctid != pvmmytid \
126	&& TEV_MASK_CHECK( pvmtrc.tmask, _kind ) )

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
120	#define BEATASK ( pvmmytid == -1 ? pvmbeatask() : 0 )

x /kat0/fletcher/SATE/2010/pvm3/include/pvmtev.h
458	#define TEV_MASK_CHECK( m, k ) ( m[ (k) / 4 ] & ( 1 << ((k) & 3) ) )

x /kat0/fletcher/SATE/2010/pvm3/include/pvmtev.h
368	#define TEV_UPKINT 63

x /kat0/fletcher/SATE/2010/pvm3/include/pvmtev.h
416	#define TEV_EVENT_ENTRY 0x4000

							/kat0/fletcher/SATE/2010/pvm3/src/lpvm.c

							Enter pvm_tc_taskexit / pvm_upkint / pvmbeatask

{

int sbf = 0, rbf = 0; /* saved rx and tx message handles */

3002

int prver; /* protocol version */

3003

int cookie; /* cookie assigned by pvmd for ident */

3004

int cc;

3005

char **ep=0;

3006

char authfn[PVMTMPNAMLEN]; /* auth file name */

x /kat0/fletcher/SATE/2010/pvm3/include/pvm3.h
565	#define PVMTMPNAMLEN 128

3007

int authfd = -1; /* auth fd to validate pvmd ident */

3008

int i;

3009

char buf[16]; /* for converting sockaddr */

3010

char *p;

3011

struct pvmminfo minfo;

3012

int outtid, outctx, outtag;

3013

int trctid, trcctx, trctag;

3014

int need_trcinfo = 0;

3015

int new_tracer = 0;

3016

char tmask[ 2 * TEV_MASK_LENGTH ];

x /kat0/fletcher/SATE/2010/pvm3/include/pvmtev.h
444	#define TEV_MASK_LENGTH 36

int tbuf, topt;

int mid;

#ifdef IMA_BEOLIN

struct hostent *hostaddr;

3021

char namebuf[128];

3022

#endif

3023

TEV_DECLS

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
135	#define TEV_DECLS int pvmamtraced; \
136	int pvmampushed = 0; \
137	int pvmtoplvlsave;

3024

#ifdef WIN32

3025

3026

/* WSAStartup has to be called before any socket command

3027

can be executed. Why ? Ask Bill

3028

3029

for (ep=environ;*ep;ep++)

3030

pvmputenv(*ep);

3031

if (WSAStartup(0x0101, &WSAData) != 0)

3032

{

3033

fprintf(stderr,"\nWSAStartup() failed\n");

3034

ExitProcess(1);

3035

}

3036

/* setsockopt(INVALID_SOCKET,SOL_SOCKET,SO_OPENTYPE, */

3037

/* (char *)&nAlert,sizeof(int)); */

#endif

pvm_setopt(PvmDebugMask, -1);

if (pvmmytid != -1)

return 0;

	3046						pvmmydsig = pvmgetdsig();

									/kat0/fletcher/SATE/2010/pvm3/src/pmsg.c

									Enter pvm_tc_taskexit / pvm_upkint / pvmbeatask / pvmgetdsig

{

static int myfmt = -1;

short i0;

int i1;

long i2;

float f0;

double f1;

int i, j;

int fmt;

if (myfmt != -1)

return myfmt;

fmt = 0;

i0 = 0;

for (i = 0; i < sizeof(i0); i++)

357

i0 += (short)i << (i * 8);

358

fmt |= ibol(0, (char *) &i0, (int) sizeof(i0));

359

360

i1 = 0;

361

for (i = 0; i < sizeof(i1); i++)

362

i1 += (int)i << (i * 8);

363

fmt |= ibol(5, (char *) &i1, (int) sizeof(i1));

364

365

i2 = 0;

366

for (i = 0; i < sizeof(i2); i++)

367

i2 += (long)i << (i * 8);

368

fmt |= ibol(10, (char *) &i2, (int) sizeof(i2));

369

370

f0 = 1.0;

371

fmt |= fbol(15, (unsigned char *) &f0, (int) sizeof(f0));

372

373

f1 = 1.0;

374

fmt |= fbol(21, (unsigned char *) &f1, (int) sizeof(f1));

myfmt = fmt;

return fmt;

}

x Problem
tid is uninitialized

									Exit pvm_tc_taskexit / pvm_upkint / pvmbeatask / pvmgetdsig

3047

3048

TEV_EXCLUSIVE;

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
139	#define TEV_EXCLUSIVE ( (pvmamtraced = pvmtoplvl) != 0 \
140	&& (pvmtoplvl = 0) == 0 )

authfn[0] = 0;

#ifndef WIN32

pvmmyupid = getpid();

3054

#else

3055

pvmmyupid = _getpid(); /* .... */

#endif

* get expected pid from environment in case we were started by

3060

* the pvmd and someone forked again

3061

3062

3063

if (p = getenv("PVMEPID"))

cookie = atoi(p);

else

cookie = 0;

/* if ((pvm_useruid = getuid()) == -1) */

3069

3070

#ifndef WIN32

3071

if ((pvm_useruid = geteuid()) == -1) {

3072

pvmlogerror("can't getuid()\n");

3073

cc = PvmSysErr;

x /kat0/fletcher/SATE/2010/pvm3/include/pvm3.h
458	#define PvmSysErr -14 /* Can't contact local daemon */

3074

goto bail2;

3075

}

3076

pvmchkuid( pvm_useruid );

3077

#else

3078

if (!username)

3079

username = MyGetUserName();

3080

#endif

3081

3082

if (p = getenv("PVMTASKDEBUG")) {

3083

pvmdebmask = pvmstrtoi(p );

3084

if (pvmdebmask) {

3085

pvmlogprintf("task debug mask is 0x%x (%s)\n",

3086

pvmdebmask, debug_flags (pvmdebmask ));

}

}

#ifndef IMA_MPP

if (cc = mksocs()) /* make socket to talk to pvmd */

goto bail2;

#endif

* initialize received-message list

3097

3098

3099

pvmrxlist = pmsg_new (1);

3100

BZERO((char*)pvmrxlist, sizeof(struct pmsg)); /* Null Pointer Dereference (ID: 22107.29040) */

x /kat0/fletcher/SATE/2010/pvm3/src/bfunc.h
63	#define BZERO(d,n) memset(d,0,n)

3101

pvmrxlist->m_link = pvmrxlist->m_rlink = pvmrxlist;

3102

3103

ttlist = TALLOC(1, struct ttpcb, "tpcb");

x /kat0/fletcher/SATE/2010/pvm3/src/pvmalloc.h
75	#define TALLOC(n,t,g) (t)PVM_ALLOC((n)sizeof(t),(g))

x /kat0/fletcher/SATE/2010/pvm3/src/pvmalloc.h
70	#define PVM_ALLOC(n,g) malloc((unsigned)(n))

3104

BZERO((char*)ttlist, sizeof(struct ttpcb)); /* Null Pointer Dereference (ID: 354.29039) */

x /kat0/fletcher/SATE/2010/pvm3/src/bfunc.h
63	#define BZERO(d,n) memset(d,0,n)

3105

ttlist->tt_link = ttlist->tt_rlink = ttlist;

3106

3107

sbf = pvm_setsbuf(pvm_mkbuf(PvmDataFoo ));

x /kat0/fletcher/SATE/2010/pvm3/include/pvm3.h
315	#define PvmDataFoo PvmDataDefault /* Internal use */

x /kat0/fletcher/SATE/2010/pvm3/include/pvm3.h
312	#define PvmDataDefault 0 /* XDR encoding */

3108

rbf = pvm_setrbuf(0);

3109

3110

3111

* create empty t-auth file that pvmd must write and we'll check later

#ifndef IMA_MPP

#ifndef NOPROT

(void)PVMTMPNAMFUN (authfn );

x /kat0/fletcher/SATE/2010/pvm3/include/pvm3.h
564	#define PVMTMPNAMFUN(x) pvmtmpnam(x)

3117

#ifdef IMA_OS2

3118

if ((authfd = open(authfn, O_RDWR|O_CREAT|O_EXCL|O_TRUNC, 0600)) == -1)

3119

#else

3120

if ((authfd = open(authfn, O_RDONLY|O_CREAT|O_EXCL|O_TRUNC, 0600)) == -1)

x /usr/include/bits/fcntl.h
34	#define O_RDONLY 00

x /usr/include/bits/fcntl.h
37	#define O_CREAT 0100 /* not fcntl */

x /usr/include/bits/fcntl.h
38	#define O_EXCL 0200 /* not fcntl */

x /usr/include/bits/fcntl.h
40	#define O_TRUNC 01000 /* not fcntl */

3121

#endif

3122

{

3123

pvmlogperror(authfn );

3124

pvmlogerror("pvmbeatask() can't creat t-auth file\n");

3125

cc = PvmSysErr;

x /kat0/fletcher/SATE/2010/pvm3/include/pvm3.h
458	#define PvmSysErr -14 /* Can't contact local daemon */

goto bail2;

}

#endif

* send first connect message to pvmd

mxfersingle = 1;

prver = TDPROTOCOL;

x /kat0/fletcher/SATE/2010/pvm3/include/pvmproto.h
314	#define TDPROTOCOL 1318

3136

pvm_pkint(&prver, 1, 1);

3137

pvm_pkstr(authfn );

3138

if ((cc = msendrecv(TIDPVMD, TM_CONNECT, SYSCTX_TM )) <= 0)

x /kat0/fletcher/SATE/2010/pvm3/src/global.h
202	#define TIDPVMD 0x80000000

x /kat0/fletcher/SATE/2010/pvm3/include/pvmproto.h
360	#define TM_CONNECT (TM_FIRST+0) /* task connects */

x /kat0/fletcher/SATE/2010/pvm3/include/pvmproto.h
359	#define TM_FIRST (int)0x80010001 /* first TM_ message */

x /kat0/fletcher/SATE/2010/pvm3/include/pvmproto.h
437	#define SYSCTX_TM (SYSCTX_FIRST-1) /* ctxt for TM messages */

x /kat0/fletcher/SATE/2010/pvm3/include/pvmproto.h
435	#define SYSCTX_FIRST (int) 0x0007ffff /* first system context */

3139

goto bail;

3140

pvm_upkint(&prver, 1, 1);

3141

if (prver != TDPROTOCOL) {

x /kat0/fletcher/SATE/2010/pvm3/include/pvmproto.h
314	#define TDPROTOCOL 1318

3142

pvmlogprintf("pvmbeatask() t-d protocol mismatch (%d/%d)\n",

3143

TDPROTOCOL, prver );

x /kat0/fletcher/SATE/2010/pvm3/include/pvmproto.h
314	#define TDPROTOCOL 1318

3144

cc = PvmSysErr;

x /kat0/fletcher/SATE/2010/pvm3/include/pvm3.h
458	#define PvmSysErr -14 /* Can't contact local daemon */

3145

goto bail;

3146

}

3147

pvm_upkint(&cc, 1, 1);

3148

if (!cc) {

3149

pvmlogerror("pvmbeatask() pvmd refuses connection\n");

...

pvm_setrbuf(rbf );

}

tev_init();

if (TEV_AMEXCL) {

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
141	#define TEV_AMEXCL pvmamtraced

3414

TEV_ENDEXCL;

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
142	#define TEV_ENDEXCL ( pvmtoplvl = pvmamtraced )

}

return 0;

bail:

if (pvm_getrbuf() > 0)

3420

pvm_freebuf(pvm_getrbuf());

3421

if (pvm_getsbuf() > 0)

3422

pvm_freebuf(pvm_getsbuf());

pvm_setrbuf(rbf );

pvm_setsbuf(sbf );

#ifndef IMA_MPP

if (authfd != -1)

(void)close(authfd); /* Double Close (ID: 351.29035) */

3429

if (authfn[0])

3430

(void)unlink(authfn); /* File System Race Condition (ID: 352.29037) */

unmksocs();

#endif

bail2:

if (TEV_AMEXCL) {

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
141	#define TEV_AMEXCL pvmamtraced

3436

TEV_ENDEXCL;

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
142	#define TEV_ENDEXCL ( pvmtoplvl = pvmamtraced )

}

return cc;

}

x Problem
tid is uninitialized

							Exit pvm_tc_taskexit / pvm_upkint / pvmbeatask

1266

ad = (long)np;

1267

TEV_PACK_LONG( TEV_DID_PDA, TEV_DATA_SCALAR, &ad, 1, 1 );

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
179	#define TEV_PACK_LONG( _did, _array, _datap, _cnt, _std ) \
180	(pvmtrccodef->enc_long)( _did, _array, \
181	(void *)(_datap), _cnt, _std )

x /kat0/fletcher/SATE/2010/pvm3/include/pvmtev.h
230	#define TEV_DID_PDA 71

x /kat0/fletcher/SATE/2010/pvm3/include/pvmtev.h
144	#define TEV_DATA_SCALAR 0x00

1268

TEV_PACK_INT( TEV_DID_PC, TEV_DATA_SCALAR, &cnt, 1, 1 );

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
171	#define TEV_PACK_INT( _did, _array, _datap, _cnt, _std ) \
172	(pvmtrccodef->enc_int)( _did, _array, \
173	(void *)(_datap), _cnt, _std )

x /kat0/fletcher/SATE/2010/pvm3/include/pvmtev.h
232	#define TEV_DID_PC 73

x /kat0/fletcher/SATE/2010/pvm3/include/pvmtev.h
144	#define TEV_DATA_SCALAR 0x00

1269

TEV_PACK_INT( TEV_DID_PSD, TEV_DATA_SCALAR, &std, 1, 1 );

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
171	#define TEV_PACK_INT( _did, _array, _datap, _cnt, _std ) \
172	(pvmtrccodef->enc_int)( _did, _array, \
173	(void *)(_datap), _cnt, _std )

x /kat0/fletcher/SATE/2010/pvm3/include/pvmtev.h
233	#define TEV_DID_PSD 74

x /kat0/fletcher/SATE/2010/pvm3/include/pvmtev.h
144	#define TEV_DATA_SCALAR 0x00

1270

TEV_FIN;

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
133	#define TEV_FIN tev_fin()

}

}

if (cnt < 0)

cc = PvmBadParam;

x /kat0/fletcher/SATE/2010/pvm3/include/pvm3.h
449	#define PvmBadParam -2 /* Bad parameter */

1276

else if (!pvmrbuf)

1277

cc = PvmNoBuf;

x /kat0/fletcher/SATE/2010/pvm3/include/pvm3.h
459	#define PvmNoBuf -15 /* No current buffer */

1278

else

1279

cc = (pvmrbuf->m_codef->dec_int) (pvmrbuf, (void*)np, cnt, std, sizeof(int));

1280

1281

if (TEV_AMEXCL) {

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
141	#define TEV_AMEXCL pvmamtraced

1282

if (TEV_DO_TRACE (TEV_UPKINT ,TEV_EVENT_EXIT )) {

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
130	#define TEV_DO_TRACE( _kind, _entry_exit ) \
131	( TEV_CHECK_TRACE( _kind ) && tev_begin( _kind, _entry_exit ) )

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
124	#define TEV_CHECK_TRACE( _kind ) \
125	( !BEATASK && pvmtrc.trctid > 0 && pvmtrc.trctid != pvmmytid \
126	&& TEV_MASK_CHECK( pvmtrc.tmask, _kind ) )

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
120	#define BEATASK ( pvmmytid == -1 ? pvmbeatask() : 0 )

x /kat0/fletcher/SATE/2010/pvm3/include/pvmtev.h
458	#define TEV_MASK_CHECK( m, k ) ( m[ (k) / 4 ] & ( 1 << ((k) & 3) ) )

x /kat0/fletcher/SATE/2010/pvm3/include/pvmtev.h
368	#define TEV_UPKINT 63

x /kat0/fletcher/SATE/2010/pvm3/include/pvmtev.h
417	#define TEV_EVENT_EXIT 0x8000

1283

TEV_PACK_INT( TEV_DID_CC, TEV_DATA_SCALAR, &cc, 1, 1 );

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
171	#define TEV_PACK_INT( _did, _array, _datap, _cnt, _std ) \
172	(pvmtrccodef->enc_int)( _did, _array, \
173	(void *)(_datap), _cnt, _std )

x /kat0/fletcher/SATE/2010/pvm3/include/pvmtev.h
163	#define TEV_DID_CC 4

x /kat0/fletcher/SATE/2010/pvm3/include/pvmtev.h
144	#define TEV_DATA_SCALAR 0x00

1284

TEV_FIN;

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
133	#define TEV_FIN tev_fin()

1285

}

1286

TEV_ENDEXCL;

x /kat0/fletcher/SATE/2010/pvm3/src/tevmac.h
142	#define TEV_ENDEXCL ( pvmtoplvl = pvmamtraced )

1287

}

1288

return (cc < 0 ? lpvmerr("pvm_upkint", cc ) : PvmOk);

x /kat0/fletcher/SATE/2010/pvm3/include/pvm3.h
448	#define PvmOk 0 /* Success */

tid is uninitialized

1289

}

x Problem
tid is uninitialized

					Exit pvm_tc_taskexit / pvm_upkint

1518

1519

if (pvmdebmask & PDMROUTE) {

x /kat0/fletcher/SATE/2010/pvm3/src/global.h
301	#define PDMROUTE 0x04000 /* message routing */

1520

pvmlogprintf("pvm_tc_taskexit() TASKEXIT for t%x\n", tid ); /* Uninitialized Variable (ID: 409.29127) */

}

* v3.3: for now, don't close fully open route as we may lose

1525

* messages. rely on socket getting EOF

1526

tid is uninitialized

1527

if ((pcbp = ttpcb_find (tid )) /* Uninitialized Variable */

x Problem
tid is uninitialized

Preconditions

((char*)&((char*)$unknown_10915588)[56])[24] = 1
myfmt = -1
pvmautoerr = 0
pvmmytid = -1
pvmtoplvl != 0

Postconditions

((char*)&((char*)$unknown_10915588)[56])[24]' = ((char*)&((char*)$unknown_10915588)[56])[24] - 1
((char*)$unknown_10915588)[56]' = &freefrags.fr_link
freefrags.fr_rlink' = ((char*)&$unknown_10915588)[56]
pvm_errno' = -15
pvmmytid' != -1
pvmrbuf' = 0
pvmtrc.trctid' <= 0
topvmd' = 0

Change Warning 408.29126 : Uninitialized Variable

Priority:
State:
Finding:
Owner:
Note: