Text  |   XML   |   Visible Warnings:

Pvm : Pvm analysis 1 : Null Pointer Dereference  at ddpro.c:907

Categories: LANG.MEM.NPD CWE:476
Warning ID: 2518.2549
Procedure: addhosts
Trace: View
Modified: Wed Sep 2 12:40:07 2009   show details
 
Priority: None
State: None
Finding: None
Owner: None
  edit properties

Legend [ X ]
Warning Location
Contributes
Parse Error
Other Warning
Two or More Loop Iterations
On Execution Path
Comment
Macro
Preprocessor
Include
Keyword
Preprocessed Away
Legend
Warning Location Contributes Parse Error
Other Warning Two or More Loop Iterations On Execution Path
Comment Macro Preprocessor
Include Keyword Preprocessed Away

Source  |  Language: C Hide Legend     
ProblemLineSource
   /u1/paul/SATE/2010/c/pvm/pvm3/src/ddpro.c
   Enter addhosts
 840 addhosts(mp, rmp) 
 841         struct pmsg *mp;        /* the request message */ 
 842         struct pmsg *rmp;       /* reply message blank */ 
 843 {
 844         struct hostd *hp, *hp2;
 845         struct pmsg *mp2;
 846         struct waitc *wp = 0;
 847         struct waitc_add *wxp = 0;
 848         int i, j;
 849         int count;
 850         int ngood;
 851         int ntid;
 852         struct hostent *he;
 853         int maxhostid = (tidhmask >> ffs(tidhmask) - 1);
 854         int hh;
 855         int pid;
 856         int *tids;
 857         char *winpvmdpath;
 858         char *pvmdpath;
 859         char *vmid;
 860         char *buf;
 861         int len;
 862  
 863         /*
 864         * have to lock this for 2 reasons:
 865         *  1. system can't handle overlapping host table updates,
 866         *  2. the new host tids aren't reserved 
 867         */ 
 868         if (busyadding) {
 869 /*
 870                 pvmlogerror("addhosts() already adding new hosts\n");
 871 */ 
 872                 pkint(rmp, PvmAlready);
 873                 sendmessage(rmp);
 874                 return 0;
 875         }
 876  
 877         busyadding = 1;
 878  
 879         /* sanity check count */ 
 880  
 881         if (upkint(mp, &count) || count < 1 || count > maxhostid) {
 882                 pvmlogerror("addhosts() bad msg format\n");
 883                 goto bad;
 884         }
 885  
 886         /*
 887         * make wait context, extract host list from message,
 888         */ 
 889  
 890         wp = wait_new(WT_HOSTSTART);
 891         wp->wa_tid = mp->m_src;
 892         wp->wa_dep = mp->m_wid;
 893         wxp = TALLOC(1, struct waitc_add, "waix");
 894         wxp->w_num = count;   /* Null Pointer Dereference (ID: 2522.2553) */
 895         wxp->w_hosts = TALLOC(count, struct hostd *, "waiv");
 896         BZERO((char*)wxp->w_hosts, count * sizeof(struct hostd *));   /* Null Pointer Dereference (ID: 2521.2552) */
 897         wp->wa_spec = (void *)wxp;
 898  
 899         for (i = 0; i < count; i++) {
true900                 hp = hd_new(0);
 901                 wxp->w_hosts[i] = hp;
 902                 if (upkstralloc(mp, &buf)) {
 903                         pvmlogerror("addhosts() bad msg format\n");
 904                         goto bad;
 905                 }
 906                 if (parsehost(buf, hp)) {
hp <= 4095907                         hp->hd_err = PvmBadParam;     /* Null Pointer Dereference */
 908  
 909                 } else {
 910  
 911                 /* Set unspecified fields from hostfile if available */ 
 912  
 913                         if (filehosts &&
 914                                         ((hp2 = nametohost(filehosts, hp->hd_name)) 
 915                                         || (hp2 = filehosts->ht_hosts[0])))
 916                                 applydefaults(hp, hp2);
 917                 }
 918                 PVM_FREE(buf);
Preconditions 
&$unknown_328270 >= 3
&$unknown_328273 = 0
&$unknown_328274 >= 1
&$unknown_328275 = -1
busyadding = 0
$heap_20648 != 0
strlen(&$heap_20648) != 0
Postconditions 
waitlist->wa_link->wa_rlink' = &$heap_20644
waitlist->wa_link->wa_rlink->wa_link' = &$heap_20644
atnewline' = 1
buf' = &$heap_20648
busyadding' = 1
count' = &$unknown_328270
$heap_20644' = waitlist->wa_link
bytes_after(&$heap_20644)' = 80
$heap_20644' is allocated by malloc
$heap_20644' is allocated
bytes_before(&$heap_20644)' = 0
((char*)&$heap_20644)[20]' = 3
((char*)&$heap_20644)[24]' = 0
((char*)&$heap_20644)[56]' = 0
((char*)&$heap_20644)[64]' = 0
((char*)&$heap_20644)[72]' = &$heap_20645
((char*)&$heap_20644)[8]' = waitlist->wa_link->wa_rlink
$heap_20645' = &$unknown_328270
bytes_after(&$heap_20645)' = 16
$heap_20645' is allocated by malloc
$heap_20645' is allocated
bytes_before(&$heap_20645)' = 0
((char*)&$heap_20645)[8]' = &$heap_20646
$heap_20646' = 0
bytes_after(&$heap_20646)' = 8 * &$unknown_328270
$heap_20646' is allocated by malloc
$heap_20646' is allocated
bytes_before(&$heap_20646)' = 0
strlen(&$heap_20646)' = 0
bytes_after(&$heap_20648)' = &$unknown_328274
$heap_20648' is allocated by malloc
bytes_before(&$heap_20648)' = 0
hp' = &$unknown_328273
maxhostid' >= 3
maxhostid' >= &$unknown_328270
mp' = $param_1
rmp' = $param_2
wp' = &$heap_20644
wxp' = &$heap_20645



Change Warning 2518.2549 : Null Pointer Dereference

Priority:
State:
Finding:
Owner:
Note: