CodeSonar : Pvm : Null Pointer Dereference

Pvm : Pvm analysis 1 : Null Pointer Dereference at ddpro.c:612

Categories:	LANG.MEM.NPD CWE:476
Warning ID:	2448.2476
Procedure:	hostfailentry
Trace:	View
Modified:	Wed Sep 2 12:39:35 2009 show details hide details

Priority:	None
State:	None
Finding:	None
Owner:	None
	edit properties

Legend	[ X ]
Warning Location Contributes Parse Error Other Warning Two or More Loop Iterations On Execution Path Comment Macro Preprocessor Include Keyword Preprocessed Away

Legend
Warning Location	Contributes	Parse Error
Other Warning	Two or More Loop Iterations	On Execution Path
Comment	Macro	Preprocessor
Include	Keyword	Preprocessed Away

Source | Language: C

Hide Legend

Problem	Line	Source

			/u1/paul/SATE/2010/c/pvm/pvm3/src/ddpro.c

			Enter hostfailentry

hostfailentry(hp)

struct hostd *hp;

{

int hpart = hp->hd_hostpart;

550

struct waitc *wp, *wp2;

551

struct pmsg *mp;

552

struct pvmmentry *ep;

553

554

if (pvmdebmask & PDMHOST) {

555

pvmlogprintf("hostfailentry() host %s\n", hp->hd_name );

hd_dump(hp );

}

if (hp == hosts->ht_hosts[hosts->ht_master]) {

560

pvmlogerror("hostfailentry() lost master host, we're screwwwed\n");

pvmbailout(0);

}

* if we're master pvmd, send HT_DEL message to all others

566

567

568

if (hp->hd_hostpart && hosts->ht_master == hosts->ht_local) {

struct hostd *hp2;

int hh;

mp = mesg_new (0);

mp->m_tag = DM_HTDEL; /* Null Pointer Dereference (ID: 2450.2478) */

574

pkint(mp, hosts->ht_serial );

575

pkint(mp, hp->hd_hostpart );

576

for (hh = hosts->ht_last; hh > 0; hh--)

577

if (hh != hosts->ht_local

578

&& (hp2 = hosts->ht_hosts[hh]) && hp2 != hp) {

579

mp->m_ref++;

580

mp->m_dst = hp2->hd_hostpart | TIDPVMD;

sendmessage(mp );

}

pmsg_unref(mp );

/* inform the scheduler too */

if (pvmschedtid) {

mp = mesg_new (0);

mp->m_tag = SM_HOSTX; /* Null Pointer Dereference (ID: 2449.2477) */

590

mp->m_dst = pvmschedtid;

591

pkint(mp, hp->hd_hostpart | TIDPVMD );

sendmessage(mp );

}

}

for (wp = waitlist->wa_link; wp != waitlist; wp = wp->wa_link) {

597

if (wp->wa_on && (wp->wa_on & TIDHOST) == hpart) {

598

switch (wp->wa_kind) {

599

600

case WT_ADDHOST: /* the master must have died */

601

case WT_DELHOST: /* the master must have died */

602

603

pvmlogprintf("hostfailentry() can't deal with wait kind %d\n",

wp->wa_kind );

break;

case WT_HTUPD:

if (wp->wa_peer == wp) {

int hh;

mp = mesg_new (0);

mp->m_tag = DM_HTCOMMIT; /* Null Pointer Dereference */

613

614

for (hh = hosts->ht_last; hh > 0; hh--)

615

if (hh != hosts->ht_local && (hp = hosts->ht_hosts[hh])) {

616

mp->m_ref++;

617

mp->m_dst = hp->hd_hostpart | TIDPVMD;

sendmessage(mp );

}

pmsg_unref(mp );

busyadding = 0;

sendmessage(wp->wa_mesg );

wp->wa_mesg = 0;

}

break;

case WT_SPAWN:

{

struct waitc_spawn *wxp;

int retry = 0;

int v;

wxp = (struct waitc_spawn*)wp->wa_spec;

635

636

/* mark tasks assigned to this host as failed */

637

/* (or reset if PvmTaskDefault) */

638

639

for (v = wxp->w_veclen; v-- > 0; )

640

if (wxp->w_vec[v] == hp->hd_hostpart)

641

if (!(wxp->w_flags

642

& (PvmTaskHost|PvmTaskArch)))

{

wxp->w_vec[v] = 0;

retry++;

}

else

wxp->w_vec[v] = PvmHostFail;

649

650

ht_delete(wxp->w_ht, hp );

651

652

/* try assigning task again without failed host */

if ( retry )

assign_tasks(wp );

/* is this was the last wait, reply to task */

658

659

if (wp->wa_peer == wp)

assign_tasks(wp );

}

break;

case WT_TASK:

/* send message if we're the last waiter */

667

668

if (wp->wa_peer == wp) {

mp = wp->wa_mesg;

mp->m_ref++;

sendmessage(mp );

}

break;

case WT_HOSTSTART:

/* reply to waiter */

busyadding = 0;

if (wp->wa_spec) {

free_waitc_add((struct waitc_add *)wp->wa_spec );

682

wp->wa_spec = 0;

683

}

684

pkint(wp->wa_mesg, PvmDSysErr );

685

sendmessage(wp->wa_mesg );

wp->wa_mesg = 0;

break;

case WT_TASKX:

if (wp->wa_tid && wp->wa_mesg) {

691

sendmessage(wp->wa_mesg );

wp->wa_mesg = 0;

}

mb_tidy(wp->wa_on );

break;

case WT_RESET:

if (wp->wa_tid && wp->wa_mesg) {

699

sendmessage(wp->wa_mesg );

700

wp->wa_mesg = 0;

701

}

702

mb_tidy_reset(wp->wa_on );

break;

case WT_RECVINFO:

/* clean up pending recvinfo */

707

ep = (struct pvmmentry *) wp->wa_spec;

708

if ( ep->me_msg ) /* class name (overload :-Q) */

709

PVM_FREE( ep->me_msg );

PVM_FREE( ep );

break;

case WT_HOSTF:

sendmessage(wp->wa_mesg );

wp->wa_mesg = 0;

break;

case WT_PSTAT:

case WT_MSTAT:

case WT_HOSTSYNC:

pkint(wp->wa_mesg, PvmHostFail );

722

sendmessage(wp->wa_mesg );

wp->wa_mesg = 0;

break;

default:

pvmlogprintf("hostfailentry() alien wait kind %d\n",

wp->wa_kind );

break;

}

wp2 = wp->wa_rlink;

wait_delete(wp );

wp = wp2;

Preconditions

&$unknown_72264 != $param_1
&$unknown_72292 != waitlist
((char*)$param_1)[4] != 0
hosts->ht_local != 1
hosts->ht_last = 1
hosts->ht_master = hosts->ht_local
waitlist->wa_link != waitlist
((char*)&$unknown_72292)[20] = 6
((char*)&$unknown_72292)[24] != 0
((char*)&$unknown_72292)[40] = &$unknown_72292
numfrags != 0
numpmsgs != 0
pvmschedtid != 0

Postconditions

freefrags.fr_link->fr_link->fr_rlink' = freefrags.fr_link->fr_rlink
freepmsgs.m_link->m_link->m_rlink' = freepmsgs.m_link->m_rlink
((char*)$unknown_72278)[8]' = ((char*)&$unknown_72278)[8]
freepmsgs.m_link->m_frag' = &$unknown_72272
freefrags.fr_link->fr_rlink->fr_link' = freefrags.fr_link->fr_link
freepmsgs.m_link->m_rlink->m_link' = freepmsgs.m_link->m_link
((char*)$unknown_72278)[8]' = $unknown_72278
((char*)&$unknown_72272)[40]' = ((char*)&$unknown_72272)[40] - 1
freepmsgs.m_link' = &freepmsgs.m_link
freepmsgs.m_rlink' = &freepmsgs.m_link
hh' = hosts->ht_last - 1
hp2' = &$unknown_72264
hpart' = ((char*)$param_1)[4]
mp' = 0
numpmsgs' = 0
wp' = &$unknown_72292

Change Warning 2448.2476 : Null Pointer Dereference

Priority:
State:
Finding:
Owner:
Note: