Text  |   XML   |   Visible Warnings:

Irssi : Irssi analysis 1 : Ignored Return Value  at log.c:138

Categories: LANG.FUNCS.IRV CWE:252 CWE:253 POW10:7
Warning ID: 2407.2422
Procedure: log_start_logging
Trace: View
Modified: Wed Sep 2 12:25:26 2009   show details
 
Priority: None
State: None
Finding: None
Owner: None
  edit properties

Legend [ X ]
Warning Location
Contributes
Parse Error
Other Warning
Two or More Loop Iterations
On Execution Path
Comment
Macro
Preprocessor
Include
Keyword
Preprocessed Away
Legend
Warning Location Contributes Parse Error
Other Warning Two or More Loop Iterations On Execution Path
Comment Macro Preprocessor
Include Keyword Preprocessed Away

Source  |  Language: C Hide Legend     
LineSource
  /u1/paul/SATE/2010/c/irssi/irssi-0.8.14/src/core/log.c
  Enter log_start_logging
98 int log_start_logging(LOG_REC *log) 
99 {
100         char *dir;
101         struct flock lock;
102  
103         g_return_val_if_fail(log != NULL, FALSE);
104  
105         if (log->handle != -1)
106                 return TRUE;
107  
108         /* Append/create log file */ 
109         g_free_not_null(log->real_fname);
110         log->real_fname = log_filename(log);
111  
112         if (log->real_fname != NULL &&
113             strcmp(log->real_fname, log->fname) != 0) {
114                 /* path may contain variables (%time, $vars),
115                    make sure the directory is created */ 
116                 dir = g_path_get_dirname(log->real_fname);
117                 mkpath(dir, log_dir_create_mode);
118                 g_free(dir);
119         }
120  
121         log->handle = log->real_fname == NULL ? -1 : 
122                 open(log->real_fname, O_WRONLY | O_APPEND | O_CREAT,
123                      log_file_create_mode);
124         if (log->handle == -1) {
125                 signal_emit("log create failed", 1, log);
126                 log->failed = TRUE;
127                 return FALSE;
128         }
129         memset(&lock, 0, sizeof(lock));
130         lock.l_type = F_WRLCK;
131         if (fcntl(log->handle, F_SETLK, &lock) == -1 && errno == EACCES) {
132                 close(log->handle);
133                 log->handle = -1;
134                 signal_emit("log locked", 1, log);
135                 log->failed = TRUE;
136                 return FALSE;
137         }
138         lseek(log->handle, 0, SEEK_END);     /* Ignored Return Value */
139  
140         log->opened = log->last = time(NULL);
141         log_write_timestamp(log->handle,
142                             settings_get_str("log_open_string"),
143                             "\n", log->last);
144  
145         signal_emit("log started", 1, log);
146         log->failed = FALSE;
147         return TRUE;
148 } 



Change Warning 2407.2422 : Ignored Return Value

Priority:
State:
Finding:
Owner:
Note: