CodeSonar : Irssi : Ignored Return Value

Home › Irssi › Irssi analysis 1 › Warning 2400.2414

Irssi : Irssi analysis 1 : Ignored Return Value at lastlog.c:205

Categories:

LANG.FUNCS.IRV CWE:252 CWE:253 POW10:7

Warning ID:

2400.2414

Similar Warnings:

2400.2415

Procedure:

show_lastlog

Trace:

Modified:

Wed Sep 2 12:25:23 2009 show details

Priority:	None
State:	None
Finding:	None
Owner:	None
	edit properties

Legend	[ X ]
Warning Location Contributes Parse Error Other Warning Two or More Loop Iterations On Execution Path Comment Macro Preprocessor Include Keyword Preprocessed Away

Legend
Warning Location	Contributes	Parse Error
Other Warning	Two or More Loop Iterations	On Execution Path
Comment	Macro	Preprocessor
Include	Keyword	Preprocessed Away

Source | Language: C

Hide Legend

Line	Source

		/u1/paul/SATE/2010/c/irssi/irssi-0.8.14/src/fe-text/lastlog.c

		Enter show_lastlog

static void show_lastlog(const char *searchtext, GHashTable *optlist,

int start, int count, FILE *fhandle)

{

WINDOW_REC *window;

LINE_REC *startline;

GList *list, *tmp;

GString *line;

char *str;

int level, before, after, len;

level = cmd_options_get_level("lastlog", optlist );

if (level == -1) return; /* error in options */

if (level == 0) level = MSGLEVEL_ALL;

if (g_hash_table_lookup(optlist, "clear") != NULL) {

textbuffer_view_remove_lines_by_level (WINDOW_GUI(active_win)->view, MSGLEVEL_LASTLOG );

if (*searchtext == '\0')

return;

}

/* which window's lastlog to look at? */

window = active_win;

str = g_hash_table_lookup(optlist, "window");

if (str != NULL) {

window = is_numeric (str, '\0') ?

window_find_refnum (atoi(str)) :

window_find_item (NULL, str );

if (window == NULL) {

printformat (NULL , NULL , MSGLEVEL_CLIENTERROR ,

TXT_REFNUM_NOT_FOUND, str );

return;

}

}

if (g_hash_table_lookup(optlist, "new") != NULL)

startline = textbuffer_view_get_bookmark (WINDOW_GUI(window)->view, "lastlog_last_check");

else if (g_hash_table_lookup(optlist, "away") != NULL)

startline = textbuffer_view_get_bookmark (WINDOW_GUI(window)->view, "lastlog_last_away");

else

startline = NULL;

if (startline == NULL)

startline = textbuffer_view_get_lines(WINDOW_GUI(window)->view);

str = g_hash_table_lookup(optlist, "#");

if (str != NULL) {

before = after = atoi(str);

} else {

str = g_hash_table_lookup(optlist, "before");

before = str == NULL ? 0 : *str != '\0' ?

atoi(str) : DEFAULT_LASTLOG_BEFORE;

str = g_hash_table_lookup(optlist, "after");

if (str == NULL) str = g_hash_table_lookup(optlist, "a");

after = str == NULL ? 0 : *str != '\0' ?

atoi(str) : DEFAULT_LASTLOG_AFTER;

}

list = textbuffer_find_text (WINDOW_GUI(window)->view->buffer, startline,

level, MSGLEVEL_LASTLOG,

searchtext, before, after,

g_hash_table_lookup(optlist, "regexp") != NULL,

g_hash_table_lookup(optlist, "word") != NULL,

g_hash_table_lookup(optlist, "case") != NULL );

len = g_list_length(list);

if (count <= 0)

tmp = list;

else {

int pos = len-count-start;

if (pos < 0) pos = 0;

tmp = pos > len ? NULL : g_list_nth(list, pos);

len = g_list_length(tmp);

}

if (g_hash_table_lookup(optlist, "count") != NULL) {

printformat_window (active_win , MSGLEVEL_CLIENTNOTICE ,

TXT_LASTLOG_COUNT, len );

g_list_free(list);

return;

}

if (len > MAX_LINES_WITHOUT_FORCE && fhandle == NULL &&

g_hash_table_lookup(optlist, "force") == NULL) {

printformat_window (active_win ,

MSGLEVEL_CLIENTNOTICE|MSGLEVEL_LASTLOG,

TXT_LASTLOG_TOO_LONG, len );

g_list_free(list);

return;

}

if (fhandle == NULL && g_hash_table_lookup(optlist, "-") == NULL)

printformat (NULL , NULL , MSGLEVEL_LASTLOG , TXT_LASTLOG_START );

line = g_string_new(NULL);

while (tmp != NULL && (count < 0 || count > 0)) {

LINE_REC *rec = tmp->data;

if (rec == NULL) {

if (tmp->next == NULL)

break;

if (fhandle != NULL) {

fwrite("--\n", 3, 1, fhandle);

} else {

printformat_window (active_win ,

MSGLEVEL_LASTLOG,

TXT_LASTLOG_SEPARATOR);

}

tmp = tmp->next;

continue;

}

/* get the line text */

textbuffer_line2text (rec, fhandle == NULL, line );

if (!settings_get_bool ("timestamps")) {

struct tm *tm = localtime(&rec->info.time);

char timestamp[10];

g_snprintf(timestamp, sizeof(timestamp),

"%02d:%02d ",

tm->tm_hour, tm->tm_min);

g_string_prepend(line, timestamp);

}

/* write to file/window */

if (fhandle != NULL) {

fwrite(line->str, line->len, 1, fhandle); /* Ignored Return Value (ID: 2400.2415) */

fputc('\n', fhandle); /* Ignored Return Value */

} else {

printtext_window (active_win, MSGLEVEL_LASTLOG,

"%s", line->str );

}

count--;

tmp = tmp->next;

}

g_string_free(line, TRUE);

if (fhandle == NULL && g_hash_table_lookup(optlist, "-") == NULL)

printformat (NULL , NULL , MSGLEVEL_LASTLOG , TXT_LASTLOG_END );

textbuffer_view_set_bookmark_bottom (WINDOW_GUI(window)->view,

"lastlog_last_check");

g_list_free(list);

}

Change Warning 2400.2414 : Ignored Return Value

Because they are very similar, this warning shares annotations with warning 2400.2415.

Priority:
State:
Finding:
Owner:
Note:

www.grammatech.com processed in 2.25 seconds on Fri Sep 4 14:48:35 2009