CodeSonar : Irssi : Null Pointer Dereference

Irssi : Irssi analysis 1 : Null Pointer Dereference at perl-common.c:530

Categories:	LANG.MEM.NPD CWE:476
Warning ID:	2294.2303
Procedure:	remove_newlines
Trace:	View
Modified:	Wed Sep 2 11:57:37 2009 show details hide details

Priority:	None
State:	None
Finding:	None
Owner:	None
	edit properties

Legend	[ X ]
Warning Location Contributes Parse Error Other Warning Two or More Loop Iterations On Execution Path Comment Macro Preprocessor Include Keyword Preprocessed Away

Legend
Warning Location	Contributes	Parse Error
Other Warning	Two or More Loop Iterations	On Execution Path
Comment	Macro	Preprocessor
Include	Keyword	Preprocessed Away

Source | Language: C

Hide Legend

Problem	Line	Source

			/u1/paul/SATE/2010/c/irssi/irssi-0.8.14/src/perl/perl-common.c

			Enter perl_command

536

void perl_command(const char *cmd, SERVER_REC *server, WI_ITEM_REC *item)

537

{

538

const char *cmdchars;

539

char *sendcmd = (char *) cmd;

if (*cmd == '\0')

return;

cmdchars = settings_get_str("cmdchars");

545

if (strchr(cmdchars, *cmd) == NULL) { /* Null Pointer Dereference (ID: 2295.2304) */

546

/* no command char - let's put it there.. */

547

sendcmd = g_strdup_printf("%c%s", *cmdchars, cmd);

548

}

549

550

/* remove \r and \n from commands,

551

to make it harder to introduce a security bug in a script */

552

if(strpbrk(sendcmd, "\r\n")) {

553

if (sendcmd == cmd)

true

554

sendcmd = strdup(cmd);

sendcmd <= 4095

555

remove_newlines(sendcmd );

					Enter perl_command / remove_newlines

$param_1 <= 4095

526

static void remove_newlines(char *str)

{

char *writing = str;

for (;*str;str++) /* Null Pointer Dereference */

					Exit perl_command / remove_newlines

Preconditions

&$unknown_1187537 = $param_1
*$param_1 != 0
strlen($param_1) > 0
$unknown_1187537 != 0
strlen(&$unknown_1187537) != 0

Postconditions

cmd' = $param_1
cmdchars' = &$unknown_1187536
item' = $param_3
sendcmd' = 0
server' = $param_2
str' = 0
writing' = 0

Change Warning 2294.2303 : Null Pointer Dereference

Priority:
State:
Finding:
Owner:
Note: